Set rich_text_list with elements attribute of empty array by default#1
Merged
davidcelis merged 1 commit intomainfrom May 29, 2025
Merged
Set rich_text_list with elements attribute of empty array by default#1davidcelis merged 1 commit intomainfrom
rich_text_list with elements attribute of empty array by default#1davidcelis merged 1 commit intomainfrom
Conversation
davidcelis
approved these changes
May 29, 2025
rich_text_list with elements attribute of empty array by defaultrich_text_list with elements attribute of empty array by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset initializes
RichText::Listwithelementsattribute having[](empty array).For
rich_text_list, Slack considerselementsattribute to be required. As of today, Slack would error out whenelementsis absent, or whenelementsis null. However, they accept empty array just fine.While there is not much point of creating
rich_text_listblock without any elements, we can avoidinvalid_blockserror and still send something to Slack. This is consistent with other block definitions in the gems where required fields has default empty value