feat: implement duplicate email validation across namespaces for Contacts #438
+103
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the contact validation logic by adding checks to prevent the creation and update of contacts with duplicate email addresses across different namespaces.
It introduces a new test case to verify that an error is returned when attempting to create a contact with an email that already exists in the cluster. Additionally, it updates the indexing mechanism to support email-based queries, ensuring data integrity in contact management.
During Contact Manual migration, we noticed that we were not preventing contacts with duplicated email addresses across all namespaces, which will cause inconsistencies on the email providers, as the email providers use email addresses as indexes.
Related to:
#436