feat: add readiness-focused telemetry for all API groups #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize metrics from config/resources-metrics/ to follow the
config/services/{api}/telemetry/ structure established by quota system.
Add recording rules and alerts focused exclusively on resource readiness.
Metrics changes:
- Move Resource Manager and IAM metrics to hierarchical service structure
- Add complete Notification API metrics coverage
- Enhance all metrics with status conditions and generation tracking
- Add user_deactivations and user_preferences to IAM
Recording rules:
- Add rules tracking resources not in Ready state for Resource Manager,
IAM, and Notification APIs
- Rules evaluate every 15s to detect readiness issues quickly
Alerts:
- Add readiness alerts for Resource Manager, IAM, and Notification
- Refactor quota alerts to focus on policy and resource readiness
- Critical alerts fire after 1-2min, warnings after 5-10min to allow
reconciliation time
Contributor
scotwells
force-pushed
the
feature/resource-metrics-and-alerting
branch
from
302c4c6 to
7ec45d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reorganizes metrics configuration and adds comprehensive readiness monitoring for Resource Manager, IAM, and Notification API groups.
Changes
Metrics reorganization
config/resources-metrics/to hierarchicalconfig/services/{api}/telemetry/metrics/control-plane/structureRecording rules
Alerting rules
Structure
The new structure aligns with the quota system pattern:
config/services/{api}/telemetry/ ├── kustomization.yaml └── metrics/ └── control-plane/ ├── kustomization.yaml └── {resource}.yaml