Skip to content

Fix: support trigger_pause_status preset in alerts #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shreyas-goenka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: support trigger_pause_status preset in alerts #4323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion bundle/config/mutator/resourcemutator/apply_presets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,22 @@ func (m *applyPresets) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnos

// Apps: No presets

// Alerts: Prefix
// Alerts: Prefix, TriggerPauseStatus
for _, a := range r.Alerts {
if a == nil {
continue
}
a.DisplayName = prefix + a.DisplayName
if t.TriggerPauseStatus != "" {
paused := sql.SchedulePauseStatusPaused
if t.TriggerPauseStatus == config.Unpaused {
paused = sql.SchedulePauseStatusUnpaused
}
// Only set pause status if a schedule is defined and pause status is not already set
if a.Schedule.QuartzCronSchedule != "" && a.Schedule.PauseStatus == "" {
a.Schedule.PauseStatus = paused
}
}
}

// SQL Warehouses: Prefix, Tags
Expand Down
29 changes: 29 additions & 0 deletions bundle/config/mutator/resourcemutator/apply_target_mode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,23 @@ func mockBundle(mode config.Mode) *bundle.Bundle {
"alert1": {
AlertV2: sql.AlertV2{
DisplayName: "alert1",
Schedule: sql.CronSchedule{
QuartzCronSchedule: "0 0 12 * * ?",
},
},
},
"alert2": {
AlertV2: sql.AlertV2{
DisplayName: "alert2",
Schedule: sql.CronSchedule{
QuartzCronSchedule: "0 0 12 * * ?",
PauseStatus: sql.SchedulePauseStatusUnpaused,
},
},
},
"alert3": {
AlertV2: sql.AlertV2{
DisplayName: "alert3",
},
},
},
Expand Down Expand Up @@ -258,6 +275,18 @@ func TestProcessTargetModeDevelopment(t *testing.T) {

// Dashboards
assert.Equal(t, "[dev lennart] dashboard1", b.Config.Resources.Dashboards["dashboard1"].DisplayName)

// Alert 1: has schedule without pause status set - should be paused
assert.Equal(t, "[dev lennart] alert1", b.Config.Resources.Alerts["alert1"].DisplayName)
assert.Equal(t, sql.SchedulePauseStatusPaused, b.Config.Resources.Alerts["alert1"].Schedule.PauseStatus)

// Alert 2: has schedule with pause status already set to unpaused - should remain unpaused
assert.Equal(t, "[dev lennart] alert2", b.Config.Resources.Alerts["alert2"].DisplayName)
assert.Equal(t, sql.SchedulePauseStatusUnpaused, b.Config.Resources.Alerts["alert2"].Schedule.PauseStatus)

// Alert 3: no schedule - pause status should remain empty
assert.Equal(t, "[dev lennart] alert3", b.Config.Resources.Alerts["alert3"].DisplayName)
assert.Empty(t, b.Config.Resources.Alerts["alert3"].Schedule.PauseStatus)
}

func TestProcessTargetModeDevelopmentTagNormalizationForAws(t *testing.T) {
Expand Down