added HotRestartRequest to _deserializeMessage#2779
added HotRestartRequest to _deserializeMessage#2779jyameo wants to merge 2 commits intodart-lang:mainfrom
Conversation
|
autosubmit label was removed for dart-lang/webdev/2779, because - The status or check suite unit_test; linux; Dart main; PKG: webdev;
|
nshahan
left a comment
There was a problem hiding this comment.
LGTM but I have two questions:
- Is this a type that needs the custom wire format that is backwards compatible with the built_value version used in the debug extension?
- Can you think of any reasonable test we could add so we don't accidentally delete it in the future?
No, this type doesn’t require the custom wire format used for
Since this RPC request originates from the injected client, it requires E2E integration between Flutter tools and DWDS. I have already added some E2E tests for hot reload and hot restart over WebSockets in the Flutter repo that should catch regressions such as these. CC @nshahan |
|
Do we expect the CI failures are existing problems or do they look related to this change? |
Fixes https://buganizer.corp.google.com/issues/484292194