Update lighttable image information when crop changes in darkroom #20205
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to update metadata when done editing an image so
that any crop value changes get reflected.
Member
Author
|
@TurboGit not a 5.4.0 bug (it's been there forever?), but a trivial fix so safe, IMO, for 5.4.1. |
|
Unfortunately, this doesn't fix the issue for me, see comment in #18210 |
TurboGit
added
the
bug: wip
reloading of thumbnail data when image information
changed. This was necessary to update variable
values that changed while in darkroom.
wpferguson
removed
the
bug: wip
Member
Author
Member
Author
|
I don't like my fix, there's a better way to code it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the lighttable image information when the crop changes in darkroom.
Fixes pixls discussion https://discuss.pixls.us/t/strange-erroneous-behavior-in-file-names-upon-export-using-dimensions