Allow shortcut setting in duplicate and snapshots #20169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* there were a few buttons which could not have shortcuts set
dterrahe
approved these changes
Jan 17, 2026
Member
dterrahe
left a comment
dterrahe
left a comment
There was a problem hiding this comment.
Both changes looking good. Thanks for fixing the oversight!
TurboGit
added
bugfix
Member
|
We have a new string here, so targeting 5.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few buttons which could not have shortcuts set, and this PR attempts to fix that.
This follows a pixls.us discussion, where a solution for the side-by-side button in
snapshots.cwas suggested.I don't see anyone else attempting this, so I've tried the suggestion (which works for me) and created this PR.
While working on it, I noticed two buttons in the darkroom duplicate manager module also appeared to have no shortcut setting ability. This appears to be a different type of button set-up, so I have attempted to copy what I see in other places (using self instead of NULL). This seems to work when I tested it, but may be the wrong approach. I can easily remove the
duplicate.cchange.