Alternative simple yesno #20138
Open
Alternative simple yesno #20138
+129
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
added
the
scope: codebase
Member
|
I was about to propose that while reading your previous PR. Nice! |
Collaborator
Author
|
@TurboGit is is possible to cherry pick and merge at least the first commit introducing the macros now? |
jenshannoschwalm
force-pushed
the
alternative_simple_yesno
branch
2 times, most recently
from
eab66dd to
acf3748
Compare
Collaborator
Author
|
Added all opencl related log changes to this PR ... |
Member
Yes I can do that. |
Collaborator
Author
I reworked the different PR's a bit and now here is all related logging stuff. So no need to do so ... |
In a lot of cases we report "YES"/"NO" or "TRUE"/"FALSE", introduce two macros for code density
Using `STR_TRUEFALSE` and `STR_YESNO`
- consequently use the nts dt_print() variant for better formatting - avoid showing build logs if there isn't any or too long
jenshannoschwalm
force-pushed
the
alternative_simple_yesno
branch
from
acf3748 to
d002c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a lot of cases we report "YES"/"NO" or "TRUE"/"FALSE", introduce two macros for code density.
Second commit makes use of those