agx: fixes for 5.4.1 #20122
Merged
agx: fixes for 5.4.1 #20122
+48
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gui->reset is set; don't call gui_update from gui_init; call gui_changed after gui_update; extracted repeated code into _update_redraw_dynamic_gui, _update_pivot_slider_settings; primaries selection remains visible even when "disable adjustments" is checked; use dt_ui_label_new
Contributor
Author
|
Should this target master or darktable-5.4.x ? The extracted functions were not only extracted to remove duplication, but also to ensure consistent reentrancy behaviour (e.g. _update_pivot_slider_settings), so it'd be more risk undoing them and re-adding the individual checks. |
Member
|
@kofa73 : No targeting master is ok, I'll then merge to 5.4.1. Will review tomorrow. |
TurboGit
added
bugfix
kofa73
deleted the
agx-fixes-for-5.4.1-reentrancy-gui-init-gui-update-gui-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected fixes for 5.4.1:
darktable.gui->resetis setgui_updatefromgui_init(agx: Fix crash during initialisation #19745 (comment))gui_changedaftergui_update(agx: Fix crash during initialisation #19745 (comment))_update_redraw_dynamic_gui_update_pivot_slider_settings