Add PATCH to HttpMethods enum for service invocation #1623
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints. This is commonly required for partial updates when calling external REST APIs via Dapr service invocation. Fixes dapr#1622 Signed-off-by: Paul Lindner <plindner@metropolis.io>
lindner
force-pushed
the
add-patch-http-method
branch
from
c703f67 to
443b03d
Compare
Collaborator
|
@lindner thanks for the contribution. We will definitely need a test for this. I would recommend you an integration test too using test container to validate that the change works using the sidecar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PATCHto theHttpMethodsenum to enable usingDaprClient.invokeMethod()with PATCH requests through HTTPEndpointsTest plan
invokeMethod()for HTTPEndpoint service invocationFixes #1622