Add 'combobox-selected' class before triggering change events.#114
Open
jzamanski wants to merge 1 commit intodanielfarrell:masterfrom
Open
Add 'combobox-selected' class before triggering change events.#114jzamanski wants to merge 1 commit intodanielfarrell:masterfrom
jzamanski wants to merge 1 commit intodanielfarrell:masterfrom
Conversation
Allows change event handler to call combobox('toggle') to clear the combobox.
Author
|
Baby's first pull request. Sort of just wanted to see how PR's work. In any case, I'm binding to the change event on the source, 'consuming' the selected element, and then want to clear/reset the combobox. Since the 'combobox-selected' class is being added after the change event is fired, there's no clean way to clear/reset the combobox besides manually removing the class from the container. This was my attempt to fix that / make it do what I wanted. |
Collaborator
|
I think this will likely get deferred to the 2.0 release. Going to work to add and document publicly accessible events to allow people to customize the functionality similar to other bootstrap control at different points in the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows change event handler to call combobox('toggle') to clear the combobox.