Conversation
BarmonHammer
left a comment
BarmonHammer
left a comment
There was a problem hiding this comment.
Provide data/source for the 1.5x multiplier and the changes noted.
Thank you for contributing!
src/perks/exotic_perks.rs
Outdated
| let mut damage_mult = 1.0; | ||
| if _input.value == 10{ | ||
| damage_mult = 1.5 | ||
| } |
There was a problem hiding this comment.
Where are these values from?
These are the only values I could find for charged with blight.
Also we would need to swap from being active, to being inactive to keep TTK accurate on this perk
There was a problem hiding this comment.
I got the values from here https://mobalytics.gg/destiny-2/weapons/exotic/1802135586-touch-of-malice
There was a problem hiding this comment.
actually, I think I misunderstood what the page was saying. I think enemies take 1.5x more damage after being hit. not when they're hit
src/perks/exotic_perks.rs
Outdated
| DamageModifierResponse { | ||
| impact_dmg_scale: damage_mult, | ||
| explosive_dmg_scale: damage_mult, | ||
| crit_scale: 1.0, |
There was a problem hiding this comment.
Shouldn't the crit_scale be set to 0.0 if active?
src/perks/perk_options_handler.rs
Outdated
| Perks::SwordLogic => Some(PerkOptionData::stacking(4)), | ||
|
|
||
| //exotics | ||
| Perks::ChargedWithBlight => Some(PerkOptionData::stacking(10)), |
There was a problem hiding this comment.
Maybe just a toggle instead? Its either on or off.
…gle. data: remove mistaken damage multiplier for Charged With Blight
|
We don't have a good handle on debuffs right now, and we probably won't until an ecs-like rewrite, most debuffs are off the table for adding unless they are ubiquitous like tether or weaken where not having them seems odd. |
|
Also, the actual shooting of the blight would likely come in as an EDR but is nearly pointless because we don't support dps simulations and we really shouldn't until it's very very accurate and can simulate full load-outs |
3 participants
Add Charged With Blight trait for Touch of Malice