fix: Swap out Noble Rounds for Blessing of the Sky#145
Open
FlaminSarge wants to merge 2 commits intod2foundry:mainfrom
Open
fix: Swap out Noble Rounds for Blessing of the Sky#145FlaminSarge wants to merge 2 commits intod2foundry:mainfrom
FlaminSarge wants to merge 2 commits intod2foundry:mainfrom
Conversation
…it is what grants the damage bonus Also use perk def.into() for NobleRounds instead of magic numbers where it's used
FlaminSarge
changed the title
Member
BarmonHammer
left a comment
BarmonHammer
left a comment
There was a problem hiding this comment.
this is good to go, hash needs changed in frontend to pull @gothfemme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secondary trait grants the damage bonus, so using it here.
UI may need to be updated to hook it up to the buff like Noble Rounds currently does (toggling Noble Rounds also toggles Blessing of the Sky in UI currently).
Also use perk def.into() for NobleRounds instead of magic numbers where it's used