Fix for images not yet downloaded from the iCloud Photo Library#15
Open
gklka wants to merge 8 commits intod0ping:masterfrom
Open
Fix for images not yet downloaded from the iCloud Photo Library#15gklka wants to merge 8 commits intod0ping:masterfrom
gklka wants to merge 8 commits intod0ping:masterfrom
Conversation
d0ping
reviewed
Oct 1, 2018
| TargetAttributes = { | ||
| C3134EAE1C9C30990023B9E6 = { | ||
| CreatedOnToolsVersion = 7.2.1; | ||
| DevelopmentTeam = 9L2H2A796T; |
Owner
There was a problem hiding this comment.
Please don't specified private developer team in the example project.
| PHFetchResult *userAlbums = [PHAssetCollection fetchAssetCollectionsWithType:PHAssetCollectionTypeAlbum subtype:PHAssetCollectionSubtypeAny options:nil]; | ||
| self.fetchResults = @[smartAlbums, userAlbums]; | ||
|
|
||
| // self.fetchResults = @[userAlbums]; |
| INFOPLIST_FILE = DBAttachmentPickerControllerExample/Info.plist; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | ||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; | ||
| PRODUCT_BUNDLE_IDENTIFIER = DB.DBAttachmentPickerControllerExample; |
Owner
There was a problem hiding this comment.
Shouldn't change bundle identifier of the example project
Author
|
Corrected my repo according your requests. You could now merge my pull request if you like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user uses iCloud Photo Library in "Optimize Storage" mode, photos might have not been downloaded to the device yet (only the metadata). I added the corresponding options which let the system use network for download the image assets which the user have selected. iOS tries to give you a thumbnail until the network access happens, this way the callback could have been invoked multiple times without the necessary data to indicate it is a thumbnail or not. I also added a check which invokes the callback only once, when the final result comes in.