Add additional device_id to Qingping CGP22C sensor#1502
Merged
Ernst79 merged 1 commit intocustom-components:masterfrom Sep 18, 2025
Merged
Add additional device_id to Qingping CGP22C sensor#1502Ernst79 merged 1 commit intocustom-components:masterfrom
Ernst79 merged 1 commit intocustom-components:masterfrom
Conversation
Ernst79
requested changes
Sep 18, 2025
Collaborator
Ernst79
left a comment
Ernst79
left a comment
There was a problem hiding this comment.
LGTM, but please change as suggested
As mentioned in custom-components#1457, the CGP22C sensor can have both the device id 0x5D and 0x33. Currently we only check for 0x5D. This commit adds a check for 0x33 as well.
Ernst79
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1457 (comment)