basic review #1
Open
basic review #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mucks
force-pushed
the
mucks-basic-review
branch
from
dd4b9bf to
490cfe9
Compare
mucks
force-pushed
the
mucks-basic-review
branch
from
490cfe9 to
c6a4d4b
Compare
Member
|
@mucks , thank you for doing the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey this is just a basic review. Overall the logic looks good to me and i couldn't find any immediate security loop holes. I will do a second pass after you got everything working. Just check the
REVIEW:tags. We can also schedule a call later this week if you like.