Skip to content

Conversation

@adityachoudhari26
Copy link
Contributor

@adityachoudhari26 adityachoudhari26 commented Oct 20, 2025

Summary by CodeRabbit

  • Chores
    • Updated Helm chart version to 0.5.1
    • Removed Redis-related configuration from deployment templates, secrets, and global settings across multiple services

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

Walkthrough

The PR removes Redis URL configuration from the ctrlplane Helm chart across multiple deployment manifests, removes the redis template helper subroutine, eliminates Redis data from secrets, removes Redis configuration from values, and bumps the chart version to 0.5.1.

Changes

Cohort / File(s) Summary
Chart Version Update
charts/ctrlplane/Chart.yaml
Bumped chart version from 0.5.0 to 0.5.1.
Deployment/StatefulSet Templates
charts/ctrlplane/charts/event-queue/templates/deployment.yaml, charts/ctrlplane/charts/jobs/templates/policy-checker.yaml, charts/ctrlplane/charts/jobs/templates/timeout-checker.yaml, charts/ctrlplane/charts/pty-proxy/templates/deployment.yaml, charts/ctrlplane/charts/webservice/templates/deployment.yaml, charts/ctrlplane/charts/workspace-engine/templates/statefulset.yaml
Removed REDIS_URL environment variable blocks sourced from secretKeyRef referencing the connections secret across all six templates. Other environment variables and configurations remain unchanged.
Template Helper Removal
charts/ctrlplane/templates/_redis.tpl
Removed the ctrlplane.redisUrl Helm template subroutine that previously generated Redis connection URLs using global.redis configuration parameters.
Secrets Configuration
charts/ctrlplane/templates/secrets.yaml
Removed REDIS_URL data field from the secret definition.
Global Configuration
charts/ctrlplane/values.yaml
Removed the entire Redis configuration block (host, port, password) from global values. PostgreSQL configuration remains intact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are highly homogeneous—systematically removing REDIS_URL references across multiple files following an identical pattern. While the diff spans nine files, each change is straightforward and consistent, requiring verification that Redis configuration is cleanly removed without unintended side effects or orphaned references.

Possibly related PRs

  • feat: Add timeout checker #16: Inverse relationship—this PR adds REDIS_URL to the timeout-checker CronJob template, while the current PR removes REDIS_URL from the same template as part of a broader Redis configuration removal.

Suggested reviewers

  • jsbroks
  • zacharyblasczyk

Poem

🐰 Redis, farewell! No URLs to store,
We've swept the configs clean from every door,
From deployments to secrets, the removal's complete,
One point one now marks the Redis retreat! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: remove redis" is directly aligned with the primary changes in the pull request. The changeset systematically removes Redis-related configuration across multiple files, including REDIS_URL environment variables from deployment templates, the Redis connection URL template subroutine, Redis configuration from values.yaml, and the REDIS_URL field from secrets. The title is concise, clear, and specific enough that a teammate scanning the git history would immediately understand the intent and scope of the changes without ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-redis

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d7d361d and cebe5cd.

📒 Files selected for processing (10)
  • charts/ctrlplane/Chart.yaml (1 hunks)
  • charts/ctrlplane/charts/event-queue/templates/deployment.yaml (0 hunks)
  • charts/ctrlplane/charts/jobs/templates/policy-checker.yaml (0 hunks)
  • charts/ctrlplane/charts/jobs/templates/timeout-checker.yaml (0 hunks)
  • charts/ctrlplane/charts/pty-proxy/templates/deployment.yaml (0 hunks)
  • charts/ctrlplane/charts/webservice/templates/deployment.yaml (0 hunks)
  • charts/ctrlplane/charts/workspace-engine/templates/statefulset.yaml (0 hunks)
  • charts/ctrlplane/templates/_redis.tpl (0 hunks)
  • charts/ctrlplane/templates/secrets.yaml (0 hunks)
  • charts/ctrlplane/values.yaml (0 hunks)
💤 Files with no reviewable changes (9)
  • charts/ctrlplane/values.yaml
  • charts/ctrlplane/charts/workspace-engine/templates/statefulset.yaml
  • charts/ctrlplane/charts/jobs/templates/policy-checker.yaml
  • charts/ctrlplane/charts/event-queue/templates/deployment.yaml
  • charts/ctrlplane/charts/pty-proxy/templates/deployment.yaml
  • charts/ctrlplane/templates/secrets.yaml
  • charts/ctrlplane/charts/webservice/templates/deployment.yaml
  • charts/ctrlplane/templates/_redis.tpl
  • charts/ctrlplane/charts/jobs/templates/timeout-checker.yaml
🔇 Additional comments (1)
charts/ctrlplane/Chart.yaml (1)

5-5: Version bump aligns with Redis removal.

The patch version increment (0.5.0 → 0.5.1) is appropriate for this maintenance release. The dependencies section confirms Redis has been cleanly removed from the chart configuration.

Before releasing, verify that:

  1. All downstream deployments and documentation reflect the Redis removal.
  2. A changelog or migration guide is available for users upgrading from 0.5.0, especially if they had Redis configurations.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adityachoudhari26 adityachoudhari26 merged commit c9a22f3 into main Oct 20, 2025
2 checks passed
@adityachoudhari26 adityachoudhari26 deleted the remove-redis branch October 20, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants