Skip to content

Conversation

@craigfowler
Copy link
Member

Right now this is just one browser, with a first stab at the CI logic and test logic to do this. I've not tried any of this out locally yet but conceptually everything's here.

Right now this is just one browser, with a first stab at the CI logic
and test logic to do this.  I've not tried any of this out locally yet
but conceptually everything's here.
Copy link
Member Author

@craigfowler craigfowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will resolve #250.

Small improvements
This is to see what's happening in WebDriverExtensions.
I suspect that it's rejecting my config, but it really doesn't
need to.
This should fix the error I'm getting about the config not existing.
I made a mistake with an env variable name, so my
logic wasn't being executed.
This enables the tests in all browsers, it also attempts to improve the name of the test in BrowserStack.
I want to see the results from all the browsers, not just the first failure.
Also remove a redundant step
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants