Open
Conversation
teodutu
requested changes
Jul 8, 2025
teodutu
left a comment
There was a problem hiding this comment.
Thanks for the PR. Functionally, most of the tasks seem alright. I'll test them more thoroughly after you do the following:
- Change your line endings from DOS (
\r\n) to Unix (\n). Usedos2unix <file-name>. - Look at the linter failures [1] and fix them
- Make all
.shscripts executable again. I think this and the first error come from WSL, which by default adds DOS line endings and mounts everything asrw-r--r--. - Recompile the binary for
feeling-chainedto 64 bits rip-my-buffers-off/solution/exploit.shstill uses the 32-bit address and offset. Update it likesolve.sh- Squash your commits into a single one and reword it like so:
labs/lab-12: Add 64-bit version
<Describe your changes here>
<Your signed-off-by line here>
Let me know if you have any questions.
[1] https://github.com/cs-pub-ro/hardware-software-interface/pull/129/checks
* Updated C sources, exploits and build scripts to 64-bit * Normalised line endings to Unix LF * Restored executable bits on shell scripts * Fixed typo in indirect-business README * Updated rip-my-buffers-off exploit with 64-bit addresses Signed-off-by: Cristian Nastase <cristiannastase16@gmail.com>' && git reset --soft origin/main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Laboratory 12 from 32bits to 64 bits
Description of changes
Updated all the tasks to 64bits: