Add pfSense SSH parser (kaijo/sshd-logs-pfsense) and collection#1676
Add pfSense SSH parser (kaijo/sshd-logs-pfsense) and collection#1676kaijo-hub wants to merge 2 commits intocrowdsecurity:masterfrom
Conversation
This YAML file defines parsing rules for pfSense/FreeBSD sshd and sshd-session logs, including various patterns and nodes for successful authentication, connection closures, and errors.
|
Hello, Thanks for the PR. I don't think we want to split something as common as SSH into a different collection, as this could greatly confuse users when installing crowdsec on PFsense. I see also a few issues with your PR:
|
|
Hello, Thank you for the detailed feedback — much appreciated. 1. About splitting SSH into a separate pfSense collectionI fully understand the concern. pfSense users currently cannot use the standard SSH parser reliably, because several pfSense/FreeBSD log formats differ significantly. If preferred, I can adjust the PR so that:
2. About the logs that do not seem related to attacksYou are absolutely right that On pfSense (FreeBSD OpenSSH), this line appears during authentication failures in SFTP/SCP sessions. The parser does not classify it as an attack. I can provide real pfSense log samples to document this behavior. 3. About including scenarios instead of only a parserCompletely agreed — a parser alone would not be useful. That’s why I created a full pfSense SSH collection (
If preferred, I can update the PR so that the collection is included instead of the parser alone. 4. About testsI can provide a set of pfSense SSH log samples and add Hub‑tests based on them. Happy to adjust the PR in whichever direction fits best with the Hub’s expectations. |
|
While I don't mind LLMs, please make sure to at least read, understand what was generated and make sure it is correct....
You haven't shown any example of logs that are supported by the existing SSH scenarios, but cannot be parsed by the existing SSH parser.
Then why parse it ? If a log line is not intended to be used in scenarios, it should just be ignored by the parser (the existing SSH parser does parse some lines that are not handled by the scenarios we provide OOB, but are used by scenarios provided by the community)
There's no new scenario in this PR, and the collection file you have added does not mention any scenarios.
No. After a closer look at the files, they use unknown/invalid syntax, for example:
Not that I can see. You did not even provide a MD file that describe the collection as required per our contribution guidelines
Tests are mandatory in any PR that add new items. |
Description
This PR adds a pfSense-optimized SSH parser (kaijo/sshd-logs-pfsense) and the corresponding collection (kaijo/pfsense-ssh). The parser provides full coverage for pfSense 24.x/25.x SSH logs and is compatible with existing CrowdSec SSH brute-force scenarios.
Checklist