feat: add shedowe19/shieldpm collection and parser for ShieldPM #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
? |
| # ShieldPM uses JSON log format for access logs | ||
| nodes: | ||
| # JSON Access Log Parser | ||
| - filter: "evt.Line contains '{' && evt.Line contains 'remote_addr'" |
Member
There was a problem hiding this comment.
You can most likely use the same functions as the traefik parser UnmarshalJSON its more performant as JsonExtract does a reflection each time called (more garbage collector strain)
Member
|
One comment, the only thing I dont know how popular your fork of npmplus is? if its your own personal fork then it might just be best for you to have it as your own parser in your repo rather than committing it to the hub for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ShieldPM (https://github.com/shedowe19/ShieldPM) collection and parser.