Skip to content

Conversation

@mgara
Copy link

@mgara mgara commented Oct 5, 2017

My changes are related to multipart requests (required for uploading images)
check commit : bde6d29

The idea is to call the graph.multipart ...

I'm using this in a production system. try to rewrite or review the whole thing and integrate it to the main branch (criso/fbgraph)

Btw :
I had to synthesize my data before passing them to the formData body as below :

for (var key in _postData) {
             if (_postData.hasOwnProperty(key)) {
               let value = _postData[key]
               if(typeof(value) === "boolean"){
                 _postData[key] = _postData[key].toString()
               }
             }
           }

Basically you have to convert all the "boolean" variables in the post data to a "String" else it will throw an error.

package.json Outdated
"repository": {
"type": "git",
"url": "git://github.com/criso/fbgraph.git"
"url": "git://github.com/mgara/fbgraph.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should leave it as it was

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure ... that's why I explicitly mentioned the commit : bde6d29
And this commit is originated from my fork... but thanks for the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants