-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fixes mem0 with valkey/redis issue #4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MatthiasHowellYopp
wants to merge
41
commits into
crewAIInc:main
Choose a base branch
from
MatthiasHowellYopp:mh/fix/valkey
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fixes mem0 with valkey/redis issue #4055
MatthiasHowellYopp
wants to merge
41
commits into
crewAIInc:main
from
MatthiasHowellYopp:mh/fix/valkey
+341
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to support using mem0 with valkey/redis as external memory provider for crewai
fixes #4031
Note
Medium Risk
Touches query filter construction for
Mem0Storage.search, which can change what memories are returned for Valkey/Redis backends. Scope is limited to localMemoryinstances and is covered by new edge-case tests.Overview
Mem0Storagenow conditionally flattens searchfiltersfor localmem0.Memoryinstances when the configured vector store provider isvalkeyorredis, converting a single-condition{"AND": [...]}into a plain dict to match backends that don’t supportAND/OR.Adds targeted tests covering Valkey/Redis flattening, non-flattening for other providers and
ORcases, safe handling ofNonelocal_mem0_config/vector_store, and ensuring cloudMemoryClientcalls keep the structuredAND/ORfilter format even if a Valkey config is present.Written by Cursor Bugbot for commit 1db23ea. This will update automatically on new commits. Configure here.