Skip to content

Conversation

@AlisdairM
Copy link
Contributor

Consistent with other nested classes within the standard library. This formulation leads to slightly clearer specification for the member functions that now use appropriately qualified names.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I like this.

\indexlibrarymember{reference}{vector<bool>}%
\begin{codeblock}
namespace std {
template<size_t N> class vector<bool>::reference {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put the template-head on a separate line

\indexlibrarymember{reference}{bitset}%
\begin{codeblock}
namespace std {
template<size_t N> class bitset<N>::reference {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the template-head on a separate line.

@jensmaurer
Copy link
Member

Can you make this two commits please (keep them in this single pull request)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants