Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| subset = mems[: cfg.rerank_k] | ||
| reranked_subset = apply_reranker(query, subset, cfg.rerank_k, reranker) |
There was a problem hiding this comment.
Use ranked results for reranker subset
The hybrid search path builds baseline from hybrid_search, but the reranker is invoked with mems[:cfg.rerank_k]. mems is the unranked, filtered input order, so the LLM reranker operates on arbitrary memories instead of the top-scoring candidates from the hybrid search. In practice the reranker can ignore the best matches and reorder unrelated items, degrading result quality. The reranker should consume baseline[:cfg.rerank_k] (the ranked list) before merging back into ordered.
Useful? React with 👍 / 👎.
Summary
GraphDrivercontract and every driver implementation to honor namespace and entity-label filters, wiring the behaviour throughMemoryManager, the MeshMind client, and REST/gRPC search/list endpointsdocs/plusENVIRONMENT_NEEDS.mdandRESUME_NOTES.md, and update contributor instructions so documentation stays synchronized with code changesTesting
https://chatgpt.com/codex/tasks/task_b_68ee1c9ee92c83218cbbebce8b0667b8