-
Notifications
You must be signed in to change notification settings - Fork 140
CI: Add govulncheck / Bump main Go version #7934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the Go version to 1.25.5 across the Sync Gateway project and adds vulnerability scanning via govulncheck to the CI workflow. The upgrade affects build configurations, CI pipelines, and linting tools.
Key changes:
- Go version bumped from 1.24.x to 1.25.5 across all configuration files
- Added new
govulncheckjob to GitHub Actions CI workflow - Updated
golangci-lintaction from v7 to v9 and tool version from v2.0.2 to v2.7
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| manifest/product-config.json | Updated Go version in product manifest for main branch |
| go.mod | Updated Go directive to require version 1.25.5 |
| Jenkinsfile | Updated Go tools version for Jenkins CI pipeline |
| .github/workflows/ci.yml | Updated Go version across all CI jobs, upgraded golangci-lint action and version, added govulncheck job |
|
FYI this looks like a legitimate race in ActiveReplicator |
torcolvin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github now provide yaml anchors if we wanted to deduplicate the constants in the future https://docs.github.com/en/actions/reference/workflows-and-actions/reusing-workflow-configurations#yaml-anchors-and-aliases
609c6ad to
df73ab9
Compare
govulncheckto CI workflowmaingolangci-lintaction and tool due to Go version upgradeactiveReplicatorCommonasync reconnect function withgo:noracedirective - fails reliably after Go version change in GH ActionsIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGatewayIntegration/212/