This repository was archived by the owner on Jan 30, 2020. It is now read-only.
api,functional: dynamic metadata - fix bugs and add functional tests#1703
Merged
dongsupark merged 3 commits intocoreos:masterfrom Nov 11, 2016
Merged
api,functional: dynamic metadata - fix bugs and add functional tests#1703dongsupark merged 3 commits intocoreos:masterfrom
dongsupark merged 3 commits intocoreos:masterfrom
Conversation
added 3 commits
November 11, 2016 17:34
Call MachineState, CreateMachineState of etcdRegistry, instead of registryMux, as machine states methods will not implemented for rpcRegistry.
To avoid API incompatibility in the future, we need to get machineMetadataOp.Value embedded in a separate structure. Unit tests must be also changed accordingly.
Now that dynamic metadata is supported, we need to do machine metadata operations also in functional tests. These are nearly equivalent to the tests in api/machines_test.go. * TestMachinesList * TestMachinesListBadNextPageToken * TestMachinesPatchAddModify * TestMachinesPatchDelete * TestMachinesPatchBad
dongsupark
force-pushed
the
dongsu/dynamic-metadata
branch
from
b52b494 to
0823b91
Compare
dongsupark
pushed a commit
that referenced
this pull request
Nov 11, 2016
api,functional: dynamic metadata - fix bugs and add functional tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to merge #1642, we need to fix several things, as well as add functional tests.
Depends on #1642. I'll first merge #1642, and after that, I'll merge this PR.
As master branch would fail without this PR, I'm going to merge it right away.
Feel free to report possible bugs. I'll create another PR to handle them in the next week.
/cc @dalbani