This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: {load|unload|start|stop} and get unit code cleanups#1469
Closed
tixxdz wants to merge 13 commits intocoreos:masterfrom
Closed
fleetctl: {load|unload|start|stop} and get unit code cleanups#1469tixxdz wants to merge 13 commits intocoreos:masterfrom
tixxdz wants to merge 13 commits intocoreos:masterfrom
Conversation
added 13 commits
March 7, 2016 13:22
* tryWaitForUnitStates() tries to wait for units to reach the desired state. * getBlockAttempts() gets the correct value of how many attempts to try before giving up on an operation. These helpers will be used to make the code more consistent and clean. We do not intended to change any behaviour here.
…ate units This is a preparation patch for the next start test patch that will try to create and start units from a template unit
… getBlockAttempts()
…emplates Since we create units from a template unit, there is a real wait operation. To avoid that and be able to really test functions, just make template units global by default, later new units will be global and we won't wait forever to reach the targetstate we just assume the Desiredstate.
…ileFromTemplate()
Improve code comments about getUnitFileFromTemplate() and kill some other useless code comments.
…tion Improve getUnitFile() error handling and add some documentation to getUnitFileFromTemplate()
…th registry and filesystem
Contributor
Author
|
It seems we can trigger semaphore in the original PR #1433 so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches set aims to make the code more consistent and robust. It does not change the current behaviour just improves the code, consolidate it, more debug logs and code comments.
The main goal is to let stop, start, load and unload to share the same code base and probably avoid any corner case or bug that may related to one of these commands.
Some logic can be easily shared later when we add stop to destroy command to solve #1000
There were some TODOs in the code base that I cleaned up with the last two patches. These patches will make it easy for us to implement later #1295
This new PR is to trigger semaphoreci.