Skip to content

Conversation

@ningmingxiao
Copy link

update build doc

@openshift-ci
Copy link

openshift-ci bot commented Dec 26, 2025

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build documentation, changing the cosa helper from a shell function to a standalone script to improve usability. It also introduces support for a NO_KVM environment variable for environments without nested virtualization. My feedback focuses on improving the documentation's clarity and correctness, including suggesting a more appropriate path for the script, clarifying the need for sudo, removing extraneous whitespace, and refining sentence structure for better readability.

update build doc

Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant