Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## [0.3.0] - 2024-11-05

- Fix persistance in case of rolled back transactions.
- Filter sensible information by default
- Filter `Rails.application.config.filter_parameters` by default. Does not support procs.

## [0.2.0] - 2022-12-29

Expand Down
18 changes: 13 additions & 5 deletions lib/validation_error.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,24 @@ def self.track(invalid_model, action: invalid_model.persisted? ? "update" : "cre

def self.filter_sensible_information(details)
filter_parameters = if defined?(Rails) && Rails.respond_to?(:application)
Rails.application.config.filter_parameters.map(&:to_sym)
Rails.application.config.filter_parameters
else
[]
end
filtered_details = details.dup
filtered_details.each do |column_name, errors|
if filter_parameters.include?(column_name.to_sym)
errors.each do |error|
if error[:value].present?
error[:value] = "***"
filter_parameters.each do |filter|
must_filter = case filter
when Regexp
filter.match?(column_name)
when String, Symbol
filter.to_s == column_name.to_s
end
if must_filter
errors.each do |error|
if error[:value].present?
error[:value] = "***"
end
end
end
end
Expand Down
3 changes: 2 additions & 1 deletion test/test_validation_error.rb
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ def test_that_models_do_not_track_on_update_if_no_errors

module RailsMock
def self.application
@application ||= OpenStruct.new(config: OpenStruct.new(filter_parameters: [:password, :ssn]))
filter_parameters = [:password, :ssn, /password/]
@application ||= OpenStruct.new(config: OpenStruct.new(filter_parameters: filter_parameters))
end
end

Expand Down