Skip to content

Conversation

@giuseppe
Copy link
Member

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @giuseppe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the NEWS file to document the changes and new features introduced in crun version 1.26. It highlights enhancements in CRIU configuration, refined Linux container lifecycle management, and various bug fixes related to error handling and utility functions, ensuring a more robust and stable runtime.

Highlights

  • CRIU Configuration: Enabled setting of RPC config file via the org.criu.config annotation. crun now also reads configuration from /etc/criu/crun.conf or /etc/criu/runc.conf.
  • Linux Container Hooks: The createContainer hooks are now executed before the root filesystem is made read-only, ensuring proper setup.
  • Error Handling: Improved graceful handling of openat errors within the Linux environment.
  • Utility Functions: Added robust handling for NULL container pointers passed to the libcrun_open_proc_file() function.
  • Container Error Release: Fixed issues related to error release on various failure paths within container operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@haircommander
Copy link
Contributor

LGTM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NEWS file with the changelog for the crun-1.26 release. The changes are straightforward and document new features and bug fixes. I've found a minor typo in the changelog entry that should be corrected for clarity.

* crun-1.26

- criu: enable setting of RPC config file via annotation
org.criu.config. crun also reads /etc/criu/crun.conf or

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There appears to be a small typo here. The annotation name org.criu.config has an extra period at the end. It should be removed to accurately reflect the annotation name.

  org.criu.config. crun also reads /etc/criu/crun.conf or

@packit-as-a-service
Copy link

TMT tests failed. @containers/packit-build please check.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe merged commit 96e9b99 into containers:main Dec 22, 2025
23 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants