fix: shared IPC ns when setting shareable #4718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuhang Wei <weiyuhang2011@gmail.com>
AkihiroSuda
reviewed
Jan 23, 2026
| testFilePath := filepath.Join("/dev/shm", | ||
| fmt.Sprintf("%s-%d-%s", testutil.Identifier(t), os.Geteuid(), base.Target)) | ||
| err := os.WriteFile(testFilePath, []byte(""), 0644) | ||
| err := os.WriteFile(testFilePath, []byte(""), 0o644) |
Member
There was a problem hiding this comment.
this change is irrelevant and should be a separate commit
AkihiroSuda
reviewed
Jan 23, 2026
| sc := bufio.NewScanner(bytes.NewBufferString(stdout)) | ||
| for sc.Scan() { | ||
| //removing spaces and tabs separating items | ||
| // removing spaces and tabs separating items |
Member
There was a problem hiding this comment.
this change is irrelevant and should be a separate commit
AkihiroSuda
reviewed
Jan 23, 2026
| t.Parallel() | ||
| base := testutil.NewBase(t) | ||
| var score = "-42" | ||
| score := "-42" |
Member
There was a problem hiding this comment.
this change is irrelevant and should be a separate commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the IPC namespace is not actually shared when using the --ipc=shareable and --ipc=container:.
Steps to reproduce
This commit explicitly set the IPC namespace path to the target container’s namespace in container IPC mode.
Add assertions in the shared IPC tests to compare ipc between container1 and container2, including after restart.
Ref: #4702