Fix ck_array_put returning false on success in transaction path #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transaction path at line 125 was incorrectly returning false after successfully adding a value to the array. This inconsistency with the non-transaction path (which correctly returns true at line 105) caused ck_array_put to indicate failure when it actually succeeded. Bug found via spec-vs-src FSM workflow comparing API specifications against source implementations.
Member
|
Ouch. Tests need improving! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ck_array.c, the transaction path at line 125 incorrectly returning false after successfully adding a value to the array. This inconsistency with the non-transaction path (which correctly returns true at line 105) caused ck_array_put to indicate failure when it actually succeeded.
Bug found via spec-vs-src FSM workflow comparing API specifications against source implementations.