Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 214 additions & 0 deletions Civi/Api4/Action/ContributionPayability/GetStatus.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,214 @@
<?php

namespace Civi\Api4\Action\ContributionPayability;

use Civi\Api4\Contribution;
use Civi\Api4\Generic\AbstractAction;
use Civi\Api4\Generic\Result;
use Civi\Paymentprocessingcore\Payability\PayabilityResult;
use Civi\Paymentprocessingcore\Service\PayabilityProviderRegistry;

/**
* Get the payability status of contributions for a contact.
*
* This action queries contributions and uses registered payability providers
* to determine if each contribution can be paid now or is managed by the
* payment processor (e.g., recurring subscriptions, payment plans).
*
* @method int getContactId()
* @method $this setContactId(int $contactId)
* @method array|null getContributionStatus()
* @method $this setContributionStatus(array $status)
* @method string|null getStartDate()
* @method $this setStartDate(string $date)
* @method string|null getEndDate()
* @method $this setEndDate(string $date)
*/
class GetStatus extends AbstractAction {

/**
* Contact ID to check contributions for.
*
* @var int
* @required
*/
protected $contactId;

/**
* Filter by contribution status names.
*
* If not provided, all statuses are included.
* Example: ['Pending', 'Partially paid']
*
* @var array|null
*/
protected $contributionStatus;

Check failure on line 45 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Property Civi\Api4\Action\ContributionPayability\GetStatus::$contributionStatus type has no value type specified in iterable type array.

/**
* Filter contributions received on or after this date.
*
* Format: YYYY-MM-DD
*
* @var string|null
*/
protected $startDate;

/**
* Filter contributions received on or before this date.
*
* Format: YYYY-MM-DD
*
* @var string|null
*/
protected $endDate;

/**
* Execute the action.
*
* @param \Civi\Api4\Generic\Result $result
*
* @throws \CRM_Core_Exception
*/
public function _run(Result $result) {

Check failure on line 72 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Method Civi\Api4\Action\ContributionPayability\GetStatus::_run() has no return type specified.
$contributions = $this->loadContributions();

if (empty($contributions)) {
return;
}

// Group contributions by payment processor type
$groupedByProcessor = $this->groupByProcessorType($contributions);

// Get payability registry
$registry = $this->getPayabilityRegistry();

// Process each processor type
$payabilityResults = [];
foreach ($groupedByProcessor as $processorType => $contributionIds) {
if ($registry->hasProvider($processorType)) {
$provider = $registry->getProvider($processorType);
$providerResults = $provider->getPayabilityForContributions($contributionIds);
$payabilityResults = array_merge($payabilityResults, $providerResults);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Using array_merge here is incorrect and will lead to data corruption. When merging arrays with integer keys, array_merge re-indexes the keys, which means the contribution IDs will be lost and replaced with a 0-based index. This will break the mapping between contributions and their payability results.

To merge the arrays while preserving the integer keys, you should use array_replace() or the + operator. array_replace() is generally safer and more explicit about its behavior.

        $payabilityResults = array_replace($payabilityResults, $providerResults);

}
}

// Build final result set
foreach ($contributions as $contribution) {
$contributionId = (int) $contribution['id'];
$processorType = $contribution['payment_processor_type'] ?? NULL;

// Base contribution data
$row = [
'id' => $contributionId,
'contact_id' => (int) $contribution['contact_id'],
'total_amount' => $contribution['total_amount'],
'currency' => $contribution['currency'],
'receive_date' => $contribution['receive_date'],
'contribution_status' => $contribution['contribution_status_id:name'],
'payment_processor_type' => $processorType,
];

// Add payability info
if (isset($payabilityResults[$contributionId])) {
$payability = $payabilityResults[$contributionId];
if ($payability instanceof PayabilityResult) {
$row = array_merge($row, $payability->toArray());
}
else {

Check failure on line 117 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Else branch is unreachable because previous condition is always true.
// Handle array format from duck-typed providers
$row['can_pay_now'] = $payability['can_pay_now'] ?? NULL;

Check failure on line 119 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Offset 'can_pay_now' on *NEVER* on left side of ?? always exists and is not nullable.
$row['payability_reason'] = $payability['payability_reason'] ?? NULL;

Check failure on line 120 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Offset 'payability_reason' on *NEVER* on left side of ?? always exists and is not nullable.
$row['payment_type'] = $payability['payment_type'] ?? NULL;

Check failure on line 121 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Offset 'payment_type' on *NEVER* on left side of ?? always exists and is not nullable.
$row['payability_metadata'] = $payability['payability_metadata'] ?? [];

Check failure on line 122 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Offset 'payability_metadata' on *NEVER* on left side of ?? always exists and is not nullable.
}
}
else {
// No provider registered for this processor type
$row['can_pay_now'] = NULL;
$row['payability_reason'] = $processorType
? "No payability provider registered for processor type: {$processorType}"
: 'No payment processor associated';
$row['payment_type'] = NULL;
$row['payability_metadata'] = [];
}

$result[] = $row;
}
}

/**
* Load contributions for the contact with filters applied.
*
* @return array
*
* @throws \CRM_Core_Exception
*/
private function loadContributions(): array {

Check failure on line 146 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Method Civi\Api4\Action\ContributionPayability\GetStatus::loadContributions() return type has no value type specified in iterable type array.
$query = Contribution::get($this->checkPermissions)

Check failure on line 147 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Call to static method get() on an unknown class Civi\Api4\Contribution.
->addSelect(
'id',
'contact_id',
'total_amount',
'currency',
'receive_date',
'contribution_status_id:name',
'contribution_recur_id',
'payment_processor_id',
'payment_processor_id.payment_processor_type_id:name'
)
->addWhere('contact_id', '=', $this->contactId);

// Apply status filter
if (!empty($this->contributionStatus)) {
$query->addWhere('contribution_status_id:name', 'IN', $this->contributionStatus);
}

// Apply date filters
if (!empty($this->startDate)) {
$query->addWhere('receive_date', '>=', $this->startDate);
}
if (!empty($this->endDate)) {
$query->addWhere('receive_date', '<=', $this->endDate . ' 23:59:59');
}

$contributions = $query->execute()->getArrayCopy();

// Normalize processor type field name
foreach ($contributions as &$contribution) {
$contribution['payment_processor_type'] =
$contribution['payment_processor_id.payment_processor_type_id:name'] ?? NULL;
unset($contribution['payment_processor_id.payment_processor_type_id:name']);
}

return $contributions;
}

/**
* Group contribution IDs by payment processor type.
*
* @param array $contributions
*
* @return array<string, array<int>>
* Array keyed by processor type, containing arrays of contribution IDs.
*/
private function groupByProcessorType(array $contributions): array {

Check failure on line 194 in Civi/Api4/Action/ContributionPayability/GetStatus.php

View workflow job for this annotation

GitHub Actions / run-phpstan

Method Civi\Api4\Action\ContributionPayability\GetStatus::groupByProcessorType() has parameter $contributions with no value type specified in iterable type array.
$grouped = [];

foreach ($contributions as $contribution) {
$processorType = $contribution['payment_processor_type'] ?? '_none_';
$grouped[$processorType][] = (int) $contribution['id'];
}

return $grouped;
}

/**
* Get the payability provider registry.
*
* @return \Civi\Paymentprocessingcore\Service\PayabilityProviderRegistry
*/
private function getPayabilityRegistry(): PayabilityProviderRegistry {
return \Civi::service('paymentprocessingcore.payability_registry');
}

}
128 changes: 128 additions & 0 deletions Civi/Api4/ContributionPayability.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
<?php

namespace Civi\Api4;

/**
* ContributionPayability API - Check if contributions can be paid now.
*
* This API provides a generic way to check the payability status of
* contributions across multiple payment processors. Each processor
* extension registers a PayabilityProvider that implements
* processor-specific logic for determining if a contribution can be
* paid immediately or is managed by the payment processor.
*
* @searchable none
* @since 1.0
* @package Civi\Api4
*/
class ContributionPayability extends Generic\AbstractEntity {

/**
* Get the payability status of contributions for a contact.
*
* @param bool $checkPermissions
*
* @return \Civi\Api4\Action\ContributionPayability\GetStatus
*/
public static function getStatus($checkPermissions = TRUE) {
return (new Action\ContributionPayability\GetStatus(__CLASS__, __FUNCTION__))
->setCheckPermissions($checkPermissions);
}

/**
* Get field definitions for the entity.
*
* @param bool $checkPermissions
*
* @return \Civi\Api4\Generic\BasicGetFieldsAction
*/
public static function getFields($checkPermissions = TRUE) {
return (new Generic\BasicGetFieldsAction(__CLASS__, __FUNCTION__, function () {
return [
[
'name' => 'id',
'title' => 'Contribution ID',
'data_type' => 'Integer',
'readonly' => TRUE,
],
[
'name' => 'contact_id',
'title' => 'Contact ID',
'data_type' => 'Integer',
'readonly' => TRUE,
],
[
'name' => 'total_amount',
'title' => 'Total Amount',
'data_type' => 'Money',
'readonly' => TRUE,
],
[
'name' => 'currency',
'title' => 'Currency',
'data_type' => 'String',
'readonly' => TRUE,
],
[
'name' => 'receive_date',
'title' => 'Receive Date',
'data_type' => 'Timestamp',
'readonly' => TRUE,
],
[
'name' => 'contribution_status',
'title' => 'Contribution Status',
'data_type' => 'String',
'readonly' => TRUE,
],
[
'name' => 'payment_processor_type',
'title' => 'Payment Processor Type',
'data_type' => 'String',
'readonly' => TRUE,
],
[
'name' => 'can_pay_now',
'title' => 'Can Pay Now',
'data_type' => 'Boolean',
'readonly' => TRUE,
'description' => 'TRUE if user can pay, FALSE if managed by processor, NULL if no provider registered',
],
[
'name' => 'payability_reason',
'title' => 'Payability Reason',
'data_type' => 'String',
'readonly' => TRUE,
],
[
'name' => 'payment_type',
'title' => 'Payment Type',
'data_type' => 'String',
'readonly' => TRUE,
'description' => 'Type: one_off, subscription, or payment_plan',
],
[
'name' => 'payability_metadata',
'title' => 'Payability Metadata',
'data_type' => 'Array',
'readonly' => TRUE,
'description' => 'Processor-specific metadata',
],
];
}))->setCheckPermissions($checkPermissions);
}

/**
* Define permissions for the entity.
*
* @return array
*/
public static function permissions() {
return [
'meta' => ['access CiviCRM'],
'default' => ['access CiviContribute'],
'getStatus' => ['access CiviContribute'],
];
}

}
11 changes: 11 additions & 0 deletions Civi/Paymentprocessingcore/Hook/Container/ServiceContainer.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ public function register(): void {
new Definition(\Civi\Paymentprocessingcore\Service\WebhookHandlerRegistry::class)
)->setShared(TRUE)->setPublic(TRUE);

// Register PayabilityProviderRegistry
// MUST be shared (singleton) so provider registrations persist across service lookups
$this->container->setDefinition(
'paymentprocessingcore.payability_registry',
new Definition(\Civi\Paymentprocessingcore\Service\PayabilityProviderRegistry::class)
)->setShared(TRUE)->setPublic(TRUE);

// Register WebhookQueueService
$this->container->setDefinition(
'paymentprocessingcore.webhook_queue',
Expand Down Expand Up @@ -82,6 +89,10 @@ public function register(): void {
'Civi\Paymentprocessingcore\Service\WebhookHandlerRegistry',
'paymentprocessingcore.webhook_handler_registry'
);
$this->container->setAlias(
'Civi\Paymentprocessingcore\Service\PayabilityProviderRegistry',
'paymentprocessingcore.payability_registry'
);
$this->container->setAlias(
'Civi\Paymentprocessingcore\Service\WebhookQueueService',
'paymentprocessingcore.webhook_queue'
Expand Down
Loading
Loading