Switch to the authentication token-based runner creation workflow#24
Open
pinchartl wants to merge 2 commits intocollabora:mainfrom
Open
Switch to the authentication token-based runner creation workflow#24pinchartl wants to merge 2 commits intocollabora:mainfrom
pinchartl wants to merge 2 commits intocollabora:mainfrom
Conversation
23fcc0e to
af96ed2
Compare
Starting in GitLab v15.10 (and enabled by default in v16.0), the runner creation uses a workflow based on authentication tokens instead of registration tokens. This introduces a new runner property named system_id that needs to be passed to the /jobs/request API. Extend the runner with a new system_id parameter (passed through the environment variable 'RUNNER_SYSTEM_ID'. Additionall update the documentation in README.md to explain the new workflow. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This patch should not be merged, it should instead be replaced by a version bump once a new gitlab-runner-rs version will be tagged. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
fb1d639 to
1656cb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in GitLab v15.10 (and enabled by default in v16.0), the runner creation uses a workflow based on authentication tokens instead of registration tokens. This introduces a new runner property named system_id that needs to be passed to the /jobs/request API.
This change requires a new version of gitlab-runner-rs, see collabora/gitlab-runner-rs#23.
I haven't updated the kubernetes integration as I have no experience with that at all.