journal: Add Result-based API for better error handling#322
Open
Tonguechaude wants to merge 3 commits intocodyps:masterfrom
Open
journal: Add Result-based API for better error handling#322Tonguechaude wants to merge 3 commits intocodyps:masterfrom
Tonguechaude wants to merge 3 commits intocodyps:masterfrom
Conversation
Tonguechaude
force-pushed
the
journal-add-result
branch
3 times, most recently
from
420e526 to
68113f0
Compare
Tonguechaude
force-pushed
the
journal-add-result
branch
3 times, most recently
from
572863f to
e218c8c
Compare
Author
|
Hello @codyps, can I have some news ? |
codyps
reviewed
Sep 29, 2025
…etermine if a cast would overflow.
Tonguechaude
force-pushed
the
journal-add-result
branch
from
efbd79f to
2964608
Compare
Tonguechaude
force-pushed
the
journal-add-result
branch
from
2964608 to
8ee86cd
Compare
Author
|
@codyps can you check when you have time please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #304
Add new Result-returning variants of journal functions to provide proper error handling instead of returning raw c_int values:
The new functions use ffi_result() to convert systemd error codes into proper Rust Result types, allowing users to distinguish between success (Ok(())) and various failure conditions.
Existing API remains fully compatible with deprecation warnings to guide users toward the new error-handling functions.