Add databinding to activities#71
Add databinding to activities#71AkshayCHD wants to merge 2 commits intocoding-blocks:masterfrom AkshayCHD:binding
Conversation
|
Please fix the codacy issues and make sure the tests do not fail |
|
Check the error (UI tests) here https://travis-ci.org/coding-blocks/DigitalOceanApp/jobs/380232125 |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
============================================
- Coverage 27.39% 27.34% -0.06%
Complexity 33 33
============================================
Files 83 83
Lines 1865 1854 -11
Branches 91 91
============================================
- Hits 511 507 -4
+ Misses 1319 1312 -7
Partials 35 35
Continue to review full report at Codecov.
|
|
@championswimmer the codeclimate test renders ambiguous results, rest all tests have passed, please have a look |
|
@AkshayCHD could you not move the lines that codeclimate are complaining about to their own method? It seems to just be complaining that some code is similar (lines 207/235), which could be moved to a single method with parameters and that should fix it. EDIT: I haven't actually looked at the code in its entirety so I'm not sure how feasible this is, hence my asking. Forgot to mention this part. |
|
@alcha actually the problem is that the codes represent two cases of a switch case and although the codes look similar there are alot of case specific variables in each case. So if i create a common function i would have an overhead of checking again and again which case is it, which is not desired in my opinion. I could be wrong about it, I don't know for sure, but thank you for the suggestion. |
|
Ahhh, that makes sense then. No worries 😊 |
Used databinding in the activites java files to reduce the boilerplate code.
fixes #72