Skip to content

Conversation

@codekeyz
Copy link
Owner

@codekeyz codekeyz commented Jul 6, 2025

  • Remove pharaoh_next framework implementation & tests. No concrete plans to finish and make this usable.
  • Improve spanner routing

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2025

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (fd75d39) to head (812fd75).

Files with missing lines Patch % Lines
packages/pharaoh/lib/src/http/body.dart 64.51% 11 Missing ⚠️
packages/spanner/lib/src/tree/tree.dart 91.66% 2 Missing ⚠️
packages/pharaoh/lib/src/http/response.dart 0.00% 1 Missing ⚠️
packages/pharaoh/lib/src/http/router.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   70.87%   74.97%   +4.09%     
==========================================
  Files          43       30      -13     
  Lines        1528     1059     -469     
==========================================
- Hits         1083      794     -289     
+ Misses        445      265     -180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codekeyz codekeyz marked this pull request as ready for review July 12, 2025 14:42
@codekeyz codekeyz self-assigned this Jul 12, 2025
@codekeyz codekeyz merged commit cc6bc58 into main Jul 12, 2025
2 checks passed
@codekeyz codekeyz deleted the chore/improve-routing branch July 12, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants