feat: Add builds next option#9946
Conversation
michalsn
left a comment
michalsn
left a comment
There was a problem hiding this comment.
I'm not a big fan of introducing next, as it will require an update that we will most likely forget to make.
Additionally, removing the instructions on how to adjust the composer file manually will leave people clueless about what to do.
I would agree to introducing something like allowing a version number to be specified, for example: 4.8, 4.9, etc., which would result in a proper, explicit change - but this parameter would need to come with a detailed explanation.
|
We have a workflow for the appstarter release. What if I replace the constant for task? Honestly, I do not know if anyone uses the dev version except me. If we continue, it is advisable to specify the next CI version with the release. Because the dev has the current number 4.7.0. In fact, it's 4.7.1 or 4.8.0. module-manager won't forgive this. |
If the version can be adjusted automatically for the next minor release, then I would accept this.
Yes, it's used.
Not sure about it. As it could lead to a situation where someone thinks they are using version ie, |
|
I understand, that's why I indicated the note in the manual. |
|
| Note that this differs from the released user guide, and will pertain to the | ||
| develop branch explicitly. | ||
|
|
||
| .. note:: You should not rely on the version of the framework in your project |
There was a problem hiding this comment.
Off-topic for another PR, maybe? Should "unstable" versions have a suffixed -DEV on the version number? Like for develop branch it would be the next patch 4.7.1-DEV while 4.8 branch is 4.8-DEV? @michalsn ?
There was a problem hiding this comment.
Seems like version_compare() would handle this without a problem, so if we can automate this, then why not? Without automation, we would probably forget about it in a few weeks.
| define('LATEST_RELEASE', '^4.0'); | ||
| define('LATEST_RELEASE', '^4.7'); | ||
| define('DEVELOP_BRANCH', 'dev-develop'); | ||
| define('NEXT_MINOR', '4.8-dev'); |
There was a problem hiding this comment.
Re-adding the caret.
| define('NEXT_MINOR', '4.8-dev'); | |
| define('NEXT_MINOR', '^4.8-dev'); |
| replace_file_content( | ||
| './admin/starter/builds', | ||
| '/define\(\'NEXT_MINOR\', \'.*?\'\);/mu', | ||
| "define('NEXT_MINOR', '{$nextMinor}-dev');", |
There was a problem hiding this comment.
| "define('NEXT_MINOR', '{$nextMinor}-dev');", | |
| "define('NEXT_MINOR', '^{$nextMinor}-dev');", |
3 participants
Description
Checklist: