fix(plugin-js-packages): ignore non-json lines and warnings in stderr#966
Merged
matejchalk merged 2 commits intomainfrom Mar 5, 2025
Merged
fix(plugin-js-packages): ignore non-json lines and warnings in stderr#966matejchalk merged 2 commits intomainfrom
matejchalk merged 2 commits intomainfrom
Conversation
vmasek
previously approved these changes
Mar 5, 2025
19ce0c3 to
d0efe0c
Compare
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 6123ba1 with previous commit 703c27e. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 4 audits regressed, 11 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
579 other audits are unchanged. |
vmasek
approved these changes
Mar 5, 2025
Collaborator
vmasek
left a comment
There was a problem hiding this comment.
I think it is the same failing test, when it was happening to me I remember reading something about nx graph having some issues in nested git repositories (which we do have in test fixtures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into problem with JS packages when Node prints a deprecation warning to output. It doesn't have any effect on the audit and outdated commands, but it caused error nonetheless. Now such unrelated warnings should be ignored.