fix(utils): remove partial from mergeConfigs return type#953
Merged
matejchalk merged 2 commits intomainfrom Mar 4, 2025
Merged
fix(utils): remove partial from mergeConfigs return type#953matejchalk merged 2 commits intomainfrom
matejchalk merged 2 commits intomainfrom
Conversation
vmasek
previously approved these changes
Mar 4, 2025
Collaborator
vmasek
left a comment
There was a problem hiding this comment.
makes perfect sense, I do not recall why I left result partial (probably because all params were partial in initial design)
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 038946a with previous commit ebb4ed5. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👍 2 audits improved, 👎 3 audits regressed, 11 audits changed without impacting score🗃️ Groups
17 other groups are unchanged. 🛡️ Audits580 other audits are unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the first parameter of
mergeConfigsis a fullCoreConfig, only the subsequent parameters arePartial<CoreConfig>s, then the result must be a fullCoreConfig.This removes the need to do
mergeConfigs(...) as CoreConfigwhen using it.