fix: add toSorted polyfill as hotfix for bug in GitHub actions runner#939
Merged
matejchalk merged 1 commit intomainfrom Feb 18, 2025
Merged
fix: add toSorted polyfill as hotfix for bug in GitHub actions runner#939matejchalk merged 1 commit intomainfrom
toSorted polyfill as hotfix for bug in GitHub actions runner#939matejchalk merged 1 commit intomainfrom
Conversation
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 5cf5d1f with source commit f5f226e. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 6 audits regressed, 11 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
578 other audits are unchanged. |
matejchalk
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runner with
use: 'node20'in our GitHub action does not respect the Node 20 requirement and runs on Node 18 anyway, GitHub did not release a Node 22 runner for quite some time now and they do not communicate their plans at all, thus only reasonable thing we can do right now it to include a polyfill as execution of our code in action runner does not work and fails with no error in CI