fix(nx-plugin): adjust upload config handling

[BioPhoton]

This PR includes:

• a fix to only use upload data id the API key is set
• updated unit tests
• updated e2e tests

[github-actions]

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 478eb6d with previous commit c677fa2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🟡 53	🟡 53
Code coverage	🟢 91	🟢 90
Documentation	🔴 23	🔴 23
Security	🟡 75	🟡 75	–
Updates	🟡 77	🟡 77	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟡 61	🟡 61	–
Bug prevention	🟢 100	🟢 100	–
Code style	🟢 100	🟢 100	–

👎 3 groups regressed, 👍 2 audits improved, 👎 7 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Lighthouse	Performance	🟡 53	🟡 53
Code coverage	Code coverage metrics	🟢 91	🟢 90
JSDoc coverage	Documentation coverage	🔴 23	🔴 23

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Lighthouse	First Contentful Paint	🟨 2.7 s	🟨 2.8 s
Lighthouse	Largest Contentful Paint	🟨 3.5 s	🟨 3.4 s
Lighthouse	Total Blocking Time	🟥 2,970 ms	🟥 4,670 ms
Lighthouse	Time to Interactive	🟥 12.9 s	🟥 13.9 s
Lighthouse	Speed Index	🟨 5.5 s	🟨 5.3 s
Code coverage	Function coverage	🟩 93 %	🟩 92.8 %
Code coverage	Line coverage	🟨 90 %	🟨 89.8 %
JSDoc coverage	Types coverage	🟥 210 undocumented types	🟥 212 undocumented types
JSDoc coverage	Functions coverage	🟥 451 undocumented functions	🟥 452 undocumented functions
Lighthouse	Avoids enormous network payloads	🟩 Total size was 1,829 KiB	🟩 Total size was 1,833 KiB
Lighthouse	Minimizes main-thread work	🟥 13.0 s	🟥 16.1 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	JavaScript execution time	🟥 6.2 s	🟥 6.8 s
Lighthouse	Uses efficient cache policy on static assets	🟨 27 resources found	🟨 27 resources found
Lighthouse	Max Potential First Input Delay	🟥 1,540 ms	🟥 1,760 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 67 KiB	🟥 Potential savings of 57 KiB
Lighthouse	Initial server response time was short	🟩 Root document took 340 ms	🟩 Root document took 470 ms
Lighthouse	Server Backend Latencies	🟩 100 ms	🟩 160 ms
Lighthouse	Eliminate render-blocking resources	🟥 Potential savings of 870 ms	🟥 Potential savings of 840 ms
Lighthouse	Network Round Trip Times	🟩 10 ms	🟩 20 ms
Code coverage	Branch coverage	🟨 85.9 %	🟨 85.9 %

575 other audits are unchanged.

[matejchalk]

@BioPhoton The PR description only mentions a small adjustment to upload config, but most of the changed files are removing extensions from imports. Could you please remove those changes, or explain why they are needed?

I remember you mentioned something about import extensions before, but it's never made sense to me why that would solve anything. Unlike imports without extensions (which are CJS-only), explicit extensions work for both CJS and ESM. For my own sanity, I tried reverting the imports in ba91850 and all nx-plugin tests still pass locally and in CI (see #972). So what is the reason for changing the imports?