fix: explicitly exit process with successful code to not leave cli hanging#935
Merged
fix: explicitly exit process with successful code to not leave cli hanging#935
Conversation
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit c2e5eaf with source commit 6c0097f. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👍 1 audit improved, 👎 5 audits regressed, 11 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
579 other audits are unchanged. |
matejchalk
approved these changes
Feb 14, 2025
Collaborator
Author
|
@matejchalk I'd merge this one and have a look on the E2E separately, it looks like some output expects version in the snapshot |
Collaborator
Yes, it looks like that test is flaky. It shouldn't rely in our current version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI hangs in certain situations, we do open many sub processes and some of them maybe don't exit properly.
For immediate fix we need to explicitly exist with successful code.
closes #468