test(test-setup): add custom matchers for ui logger#923
Merged
hanna-skryl merged 10 commits intomainfrom Jan 21, 2025
Merged
Conversation
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit c440d62 with source commit 1686dda. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👍 4 audits improved, 👎 6 audits regressed, 10 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
576 other audits are unchanged. |
matejchalk
reviewed
Jan 17, 2025
packages/cli/src/lib/implementation/filter.middleware.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/print-config/print-config-command.unit.test.ts
Outdated
Show resolved
Hide resolved
60d7b79 to
7363d50
Compare
BioPhoton
approved these changes
Jan 18, 2025
Collaborator
BioPhoton
left a comment
There was a problem hiding this comment.
Really nice testing helper!
An idea I had was also providing additional matcher for severity:
toHaveLoggedWarningtoHaveNthLoggedWarning- ...
This might exceed the scope of this PR so consider it as am idea.
I approved the PR.
matejchalk
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #552
This PR adds custom matchers for
ui()logger.