feat(models): add URL source type for issues by hanna-skryl · Pull Request #1230 · code-pushup/cli

hanna-skryl · 2026-01-24T01:51:09Z

Partially addresses #677 by extending the model for issue location with sourceUrlLocationSchema.

Models:

Add sourceUrlLocationSchema
Create issueSourceSchema union type combining file and URL sources

Utils:

Add type guards
Rename issue table columns: "Source file" -> "Source", "Line(s)" -> "Location"
Add formatSelectorLocation to display only the target element in the location column to avoid verbosity

Axe plugin:

Populate the source field with a URL, an HTML snippet, and a CSS selector

Core/CI:

Handle the union type in report processing

Out of scope:

CLI upload: URL source data is not uploaded to the backend. The issueToGQL function includes source details only for file-based issues. Uploading URL sources requires changes to the Portal API first.
Portal API: Needs new fields to store URL-source data and display the full selector in the issues table (e.g., via a tooltip)

Note

The selector is temporarily duplicated in the Axe issue message (e.g., [`img`] Fix this...) for Portal backward compatibility until it supports URL source display.

nx-cloud · 2026-01-24T01:52:34Z

View your CI Pipeline Execution ↗ for commit 2b58226

Command	Status	Duration	Result
`nx run ci:code-pushup -- merge-diffs --files=/h...`	✅ Succeeded	4s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	1m 15s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	10m 31s	View ↗
`nx run-many -t unit-test,int-test`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-26 17:04:55 UTC

pkg-pr-new · 2026-01-24T01:52:46Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1230

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1230

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1230

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1230

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1230

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1230

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1230

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1230

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1230

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1230

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1230

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1230

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1230

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1230

commit: 2b58226

github-actions · 2026-01-24T01:59:42Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit dabff01 with previous commit b28073e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 32	🔴 29
Code coverage	🟢 92	🟢 92
Documentation	🔴 42	🔴 42
Bug prevention	🟡 75	🟡 75
Axe Accessibility	🟡 88	🟡 88
Code style	🟢 100	🟢 100	–
Security	🔴 47	🔴 47	–
Updates	🟡 78	🟡 78	–
Type Safety	🟡 67	🟡 67	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–

👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 8 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 32	🔴 29
Code coverage	Code coverage metrics	🟢 92	🟢 92
JSDocs coverage	Documentation coverage	🔴 42	🔴 42

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Initial server response time was short	🟩 Root document took 510 ms	🟥 Root document took 700 ms
Lighthouse	First Contentful Paint	🟥 3.4 s	🟥 3.9 s
Lighthouse	Total Blocking Time	🟥 2,610 ms	🟥 4,520 ms
Lighthouse	Time to Interactive	🟥 14.4 s	🟥 15.8 s
Lighthouse	Speed Index	🟥 8.6 s	🟥 8.5 s
JSDocs coverage	Functions coverage	🟥 577 undocumented functions	🟥 579 undocumented functions
JSDocs coverage	Types coverage	🟥 268 undocumented types	🟥 272 undocumented types
Code coverage	Function coverage	🟩 94.3 %	🟩 94.1 %
JSDocs coverage	Variables coverage	🟥 268 undocumented variables	🟥 272 undocumented variables
Code coverage	Line coverage	🟩 92.3 %	🟩 92.3 %
Code coverage	Branch coverage	🟨 89 %	🟨 89 %
Lighthouse	Minimizes main-thread work	🟥 12.7 s	🟥 17.7 s
Lighthouse	JavaScript execution time	🟥 5.0 s	🟥 8.3 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Largest Contentful Paint	🟥 12.6 s	🟥 13.9 s
Lighthouse	Max Potential First Input Delay	🟥 1,740 ms	🟥 2,980 ms
Lighthouse	Uses efficient cache policy on static assets	🟨 31 resources found	🟨 31 resources found
Lighthouse	Server Backend Latencies	🟩 820 ms	🟩 1,070 ms
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,096 KiB	🟩 Total size was 2,096 KiB
Lighthouse	Reduce unused CSS	🟥 Potential savings of 104 KiB	🟥 Potential savings of 125 KiB
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 226 KiB	🟥 Potential savings of 226 KiB
Lighthouse	Network Round Trip Times	🟩 70 ms	🟩 70 ms

657 other audits are unchanged.

github-actions · 2026-01-24T02:06:32Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit dabff01 with previous commit b28073e.

💼 Project `utils`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 95	🟢 95
Documentation	🔴 45	🔴 46

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 3 audits regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 95	🟢 95
JSDocs coverage	Documentation coverage	🔴 45	🔴 46

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Functions coverage	🟥 239 undocumented functions	🟥 241 undocumented functions
Code coverage	Function coverage	🟩 96.2 %	🟩 95.7 %
Code coverage	Branch coverage	🟩 91.8 %	🟩 91.7 %
Code coverage	Line coverage	🟩 97.8 %	🟩 97.7 %

440 other audits are unchanged.

💼 Project `plugin-axe`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🟡 70	🟡 70
Code coverage	🟢 94	🟢 94

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDocs coverage	Documentation coverage	🟡 70	🟡 70
Code coverage	Code coverage metrics	🟢 94	🟢 94

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Functions coverage	🟨 12 undocumented functions	🟨 12 undocumented functions
Code coverage	Line coverage	🟨 72.7 %	🟨 73 %
Code coverage	Branch coverage	🟨 89.9 %	🟩 90 %

440 other audits are unchanged.

💼 Project `create-cli`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 96	🟢 96

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 96	🟢 96

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟨 87.5 %	🟨 88.2 %

443 other audits are unchanged.

💼 Project `ci`

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 92	🟢 92

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 92	🟢 92

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟨 83.6 %	🟨 83.6 %
Code coverage	Line coverage	🟩 94.8 %	🟩 94.8 %

443 other audits are unchanged.

💼 Project `models`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🟡 66	🟡 66
Code coverage	🟢 94	🟢 94

2 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 1 audit regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDocs coverage	Documentation coverage	🟡 66	🟡 66
Code coverage	Code coverage metrics	🟢 94	🟢 94

10 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Variables coverage	🟥 72 undocumented variables	🟥 76 undocumented variables
Code coverage	Line coverage	🟩 99.4 %	🟩 99.4 %
JSDocs coverage	Types coverage	🟥 53 undocumented types	🟥 57 undocumented types

434 other audits are unchanged.

💼 Project `core`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 90	🟢 90

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 90	🟢 90

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟩 94.8 %	🟩 94.8 %

443 other audits are unchanged.

💼 Project `plugin-lighthouse`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 6 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 15 groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟩 98.8 %	🟩 98.8 %

443 other audits are unchanged.

7 other projects are unchanged.

matejchalk

LGTM 👍

feat(models): add URL source type for issues

81552c1

hanna-skryl self-assigned this Jan 24, 2026

github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 core 🧩 models 🧩 utils 🧩 ci 🧩 axe-plugin labels Jan 24, 2026

hanna-skryl force-pushed the issue-source-url branch from 2c85e7b to b7380c7 Compare January 24, 2026 02:08

hanna-skryl added 3 commits January 26, 2026 11:42

feat(utils): add type guards and URL source formatting

ab26349

refactor(core,ci): handle URL source union type

5173f00

feat(plugin-axe): add source field to issues

2b58226

hanna-skryl force-pushed the issue-source-url branch from b7380c7 to 2b58226 Compare January 26, 2026 16:47

hanna-skryl marked this pull request as ready for review January 26, 2026 17:07

hanna-skryl requested a review from BioPhoton as a code owner January 26, 2026 17:07

hanna-skryl requested a review from matejchalk January 26, 2026 17:07

matejchalk approved these changes Jan 26, 2026

View reviewed changes

hanna-skryl merged commit fe6f94e into main Jan 26, 2026
25 checks passed

hanna-skryl deleted the issue-source-url branch January 26, 2026 18:34

Conversation

hanna-skryl commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actions bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project utils

🗃️ Groups

🛡️ Audits

💼 Project plugin-axe

🗃️ Groups

🛡️ Audits

💼 Project create-cli

🗃️ Groups

🛡️ Audits

💼 Project ci

🗃️ Groups

🛡️ Audits

💼 Project models

🗃️ Groups

🛡️ Audits

💼 Project core

🗃️ Groups

🛡️ Audits

💼 Project plugin-lighthouse

🗃️ Groups

🛡️ Audits

Uh oh!

matejchalk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hanna-skryl commented Jan 24, 2026 •

edited

Loading

nx-cloud bot commented Jan 24, 2026 •

edited

Loading

pkg-pr-new bot commented Jan 24, 2026 •

edited

Loading

github-actions bot commented Jan 24, 2026 •

edited

Loading

github-actions bot commented Jan 24, 2026 •

edited

Loading

💼 Project `utils`

💼 Project `plugin-axe`

💼 Project `create-cli`

💼 Project `ci`

💼 Project `models`

💼 Project `core`

💼 Project `plugin-lighthouse`