refactor(plugin-lighthouse): rename category aggregation helper#1184
Merged
hanna-skryl merged 2 commits intomainfrom Dec 11, 2025
Merged
refactor(plugin-lighthouse): rename category aggregation helper#1184hanna-skryl merged 2 commits intomainfrom
hanna-skryl merged 2 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 04a2702
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 8e1ff75 with previous commit d107538. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 4 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
659 other audits are unchanged. |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 8e1ff75 with previous commit d107538. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 47 | 🔴 48 | |
| Code coverage | 🟢 99 | 🟢 99 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDoc coverage | Documentation coverage | 🔴 47 | 🔴 48 | |
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDoc coverage | Variables coverage | 🟥 20 undocumented variables | 🟥 20 undocumented variables | |
| Code coverage | Line coverage | 🟩 97.2 % | 🟩 97 % | |
| Code coverage | Branch coverage | 🟩 96.1 % | 🟩 96.1 % |
440 other audits are unchanged.
13 other projects are unchanged.
BioPhoton
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Axe plugin introduced
axeCategories(#1182) with a more intuitive naming convention that describes what you get rather than how it works internally. This PR aligns Lighthouse with the same pattern and fixes a bug discovered during the alignment work.createCategoriesreturning an empty array for single-URL configurationsmergeLighthouseCategoriestolighthouseCategoriesfor consistency with Axe plugin APImerge-categories.tstocategories.tsto align file structure