fix: resolve incomplete linting across projects

[hanna-skryl]

Fixes incomplete linting configuration that prevented ESLint from checking most TypeScript files in the repository (revealed in this discussion).

The nx.json lint target was missing quotes around the glob pattern.

Without quotes, the glob pattern was expanded before reaching ESLint. As a result, instead of matching all TypeScript files recursively, only the top-level files in each project were linted.

Once all files were properly linted, fixed the newly discovered errors across multiple projects.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 1501cbf

Command	Status	Duration	Result
nx code-pushup --nx-bail -- compare	✅ Succeeded	58s	View ↗
nx code-pushup --nx-bail --	✅ Succeeded	1m 9s	View ↗
nx code-pushup --nx-bail -- print-config --outp...	✅ Succeeded	5m 14s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-11-21 15:05:33 UTC

[pkg-pr-new]

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1151

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1151

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1151

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1151

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1151

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1151

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1151

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1151

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1151

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1151

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1151

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1151

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1151

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1151

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1151

commit: 1501cbf

[github-actions]

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 02b09b0 with previous commit 96e03ef.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 35	🔴 37
Code coverage	🟡 89	🟡 89
Documentation	🔴 35	🔴 35
Security	🔴 43	🔴 43	–
Updates	🟡 71	🟡 71	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–
Type Safety	🟢 100	🟢 100	–
Bug prevention	🟢 100	🟢 100	–
Miscellaneous	🟢 100	🟢 100	–
Code style	🟢 100	🟢 100	–

👍 2 groups improved, 👎 1 group regressed, 👍 7 audits improved, 👎 2 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Lighthouse	Performance	🔴 35	🔴 37
Code coverage	Code coverage metrics	🟡 89	🟡 89
JSDoc coverage	Documentation coverage	🔴 35	🔴 35

20 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Lighthouse	Initial server response time was short	🟥 Root document took 1,230 ms	🟩 Root document took 430 ms
Lighthouse	Speed Index	🟥 7.6 s	🟥 6.5 s
Lighthouse	Total Blocking Time	🟥 1,730 ms	🟥 1,550 ms
Lighthouse	First Contentful Paint	🟥 3.2 s	🟥 3.2 s
Lighthouse	Time to Interactive	🟥 13.4 s	🟥 13.1 s
Code coverage	Line coverage	🟨 85.2 %	🟨 85.3 %
JSDoc coverage	Variables coverage	🟥 241 undocumented variables	🟥 248 undocumented variables
Code coverage	Branch coverage	🟨 87 %	🟨 87.1 %
Code coverage	Function coverage	🟩 90.2 %	🟩 90.2 %
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,018 KiB	🟩 Total size was 2,019 KiB
Lighthouse	Minimizes main-thread work	🟥 11.3 s	🟥 12.4 s
Lighthouse	Largest Contentful Paint	🟥 11.6 s	🟥 10.9 s
Lighthouse	JavaScript execution time	🟥 4.5 s	🟥 5.0 s
Lighthouse	Uses efficient cache policy on static assets	🟨 30 resources found	🟨 30 resources found
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Server Backend Latencies	🟩 1,160 ms	🟩 890 ms
Lighthouse	Max Potential First Input Delay	🟥 1,080 ms	🟥 1,330 ms
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 105 KiB	🟥 Potential savings of 100 KiB
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 184 KiB	🟥 Potential savings of 174 KiB
Lighthouse	Network Round Trip Times	🟩 30 ms	🟩 50 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 104 KiB	🟥 Potential savings of 104 KiB
JS Packages	Vulnerabilities for NPM dev dependencies.	🟥 32 vulnerabilities (1 critical, 23 moderate, 8 low)	🟥 29 vulnerabilities (1 critical, 23 moderate, 5 low)

655 other audits are unchanged.

[matejchalk]

Thanks so much for figuring out the problem and fixing everything. 🥇

It's a shame we didn't catch this when the change was being made in #1090 and #1052. 😬