test: abbreviate integration to int, rename vitest config files#1018
Merged
matejchalk merged 2 commits intomainfrom Jun 30, 2025
Merged
test: abbreviate integration to int, rename vitest config files#1018matejchalk merged 2 commits intomainfrom
integration to int, rename vitest config files#1018matejchalk merged 2 commits intomainfrom
Conversation
Contributor
Code PushUp😟 Code PushUp report has regressed – compared current commit b7a003d with previous commit f0a2a01. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👎 7 audits regressed, 10 audits changed without impacting score🗃️ Groups
19 other groups are unchanged. 🛡️ Audits
587 other audits are unchanged. |
vmasek
approved these changes
Jun 27, 2025
Collaborator
vmasek
left a comment
There was a problem hiding this comment.
Thanks for doing this, I experimented with similar changes in past as the DX was not good testing wise.
I'll try out if JB IDE picks it up now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
integration-testrepeatedly, abbreviating toint-testwould be more convenient.vite.config.{type}.tsfile pattern doesn't realiably recognized by tooling because of the custom suffixes. Also, it may not be clear that the configuration is only for Vitest, not for Vite -vitest.config.tsnaming is another standardized config file name, which would be more appropriate in our case.Changes
*.integration.test.tsfiles to*.int.test.ts.vite.config.{unit|integration|e2e}.tsfiles tovitest.{unit|int|e2e}.config.ts.Follow-up
For running E2E tests, typing out
npx nx nxv-e2e <project>-e2eis cumbersome. I'd like to rename thenxv-e2etarget toe2e-test. Then all our testing targets would have intuitive names -unit-test,int-test,e2e-test.I've submitted a PR to
@push-based/nx-verdacciowhich adds an option to rename the inferrednxv-e2etarget. Once that's released, we can rename the target on our end.