feat(ci): make print-config and compare commands nx cache friendly#1012
Merged
matejchalk merged 2 commits intomainfrom Jun 3, 2025
Merged
feat(ci): make print-config and compare commands nx cache friendly#1012matejchalk merged 2 commits intomainfrom
matejchalk merged 2 commits intomainfrom
Conversation
ad70ea9 to
e55685f
Compare
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit b46e924 with previous commit 2135c9b. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👍 5 audits improved, 👎 3 audits regressed, 10 audits changed without impacting score🗃️ Groups
19 other groups are unchanged. 🛡️ Audits
587 other audits are unchanged. |
hanna-skryl
approved these changes
Jun 3, 2025
vmasek
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out some Nx monorepos need to cache commands like
print-configandcompareas well. Previously,--skip-nx-cachewas added in #942 due to difficulty in configuring Nx cache correctly for these commands. Adjusted the output files to match expected{workspaceRoot}/.code-pushup/{projectName}cache configuration.